[Functional Tests] Add timeout for comboBox list loading #73498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
v6.8.12
backport:skip
|
Pinging @elastic/kibana-test-triage (failed-test) |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
timroes
reviewed
Jul 28, 2020
| @@ -55,6 +56,7 @@ export function ComboBoxProvider({ getService }) { | |||
|
|
|||
| async _waitForOptionsListLoading(comboBoxElement) { | |||
| await comboBoxElement.waitForDeletedByClassName('euiLoadingSpinner'); | |||
| await PageObjects.common.sleep(1000); | |||
There was a problem hiding this comment.
Is there any element we could wait for once this is done loading, so we wouldn't need to wait with an arbitrary amount of time here?
There was a problem hiding this comment.
Unfortunately not, the problem here is that right before rendering filtered list, there's a flicker of unfiltered list with the same structure. We could try to refactor a comboBox or think about refactoring the whole test service, but as it's just 6.8, I feel like it's not worth the effort, especially because the solution above works well.
kertal
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #22233
The test that fails follows these steps:
2.1. Open comboBox
2.2. Type 'osx' to filter it out
2.3. Choose the first filtered option
Between steps 2.2 and 2.3, the comboBox flickers and shows all the options. Instead of the right one, the first one is chosen - the problem is only reproducible on cloud, probably because it's a faster, stronger environment. Adding a timeout solves the issue.
The problem with this functional test was fixed with a complete refactoring of comboBox test service for version 7+ so we only need to fix it for 6.8.
Checklist
Delete any items that are not applicable to this PR.
For maintainers